google / google/oss-rebuild

TaskQueue rebuilds should cancel GCB before timeout

Open
#320 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
714
Forks
64
Avg merge
2d 6h
Merged PRs (30d)
58

Description

Google Cloud Tasks with an HTTP target have a timeout of up to 30 minutes: https://cloud.google.com/tasks/docs/creating-http-target-tasks#handler

Most rebuilds complete within this timeframe, but for the ones that don't complete in this time we should release the resources before the timeout happens. In particular we should set a context with timeout at the beginning of the API handler (only for task-queue requests) and that context should be responsible for cancelling the GCB invokations.

I would also be interested to understand better how the cloud run invokcation handles the task queue cancelling its request. Does cloud run terminate immediately? Run until it hits its own timeout?

Contributor guide

Open the contributing guide

Research direction

Start at the API handler and the path that identifies task-queue requests. Trace how Google Cloud Build invocations are cancelled and how Cloud Run handles a cancelled task request; done means a task-queue rebuild releases its resources before the Cloud Tasks timeout, with the cancellation behavior understood.

Written by the indexing model from the issue text.

Assessment

Tech stack
gcp, go
Domain
api, backend, cloud
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.