abseil's fuzzer asserts equality between the wrong variables
- Dominant language
- Shell
- Stars
- 12.6k
- Forks
- 2.9k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 62
Description
The `abort()`s on lines 48 and 59 are dead code because the `if` comparison is testing the wrong variable
https://github.com/google/oss-fuzz/blob/461f5c9696f361a10633538dd74cf62825e3dc61/projects/abseil-cpp/string_escape_fuzzer.cc#L41-L48
https://github.com/google/oss-fuzz/blob/461f5c9696f361a10633538dd74cf62825e3dc61/projects/abseil-cpp/string_escape_fuzzer.cc#L52-L59
Found by Fable while setting up fuzzing locally.
Contributor guide
Research direction
Open projects/abseil-cpp/string_escape_fuzzer.cc and inspect the comparisons around lines 41-48 and 52-59. Confirm each condition checks the intended variables rather than the currently compared ones, then run the relevant fuzzer or validation command and verify the abort paths are reachable for mismatched results.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 90/100