google / google/osdetector-gradle-plugin

Revisit classifierWithLikes

Open
#4 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
117
Forks
22
PR merge metrics
No merged PRs in 30d

Description

Setting `classifierWithLikes` changes the content of the classifier. Because there is only one classifier instance in on JVM, if different components want different `classifierWithLikes` settings, they will run into each other. A real world example is in gRPC Java build, both tcnative artifact and protobuf-gradle-plugin are using classifier, while tcnative sets `classifierWithLikes` and protobuf-gradle-plugin doesn't.

We should either allow multiple classifiers in a JVM (by making it non-static), or remove the `classifierWithLikes` feature.

@ejona86

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.