google / google/or-tools

VRP with breaks minor bug?

Open
#4,234 4 comments 0 reactions 2 assignees Claimed by @Mizux View on GitHub
Bug Solver: Routing Solver: Routing - break
Dominant language
C++
Stars
14.1k
Forks
2.5k
Avg merge
8h 39m
Merged PRs (30d)
72

Description

**What version of OR-Tools and what language are you using?**
Version: stable branch
Language: C++

**Which solver are you using (e.g. CP-SAT, Routing Solver, GLOP, BOP, Gurobi)**
Routing Library

**What operating system (Linux, Windows, ...) and version?**
Linux Mint 21.3

**What did you do?**
Using VRP with breaks. `GlobalVehicleBreaksConstraint` will be added to the Solver.

**What did you expect to see**
I believe here we're updating `StartMin` value of the arc `path_[pos] -> path_[pos + 1]` to `EndMin` value of the break interval. This arc `StartMin` is `CumulVar(path_[pos])->Min() - arc_start_offset`. So instead of `SetMin(CapSub(interval_end_min, arc_start_offset))` it should be `SetMin(CapAdd(interval_end_min, arc_start_offset))`.

https://github.com/google/or-tools/blob/5124f4975bd6ab5a863ea55657833ab640730429/ortools/constraint_solver/routing_breaks.cc#L943-L951

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.