openintent-wifi-access_points.schema.json formatting review
- Dominant language
- No language data
- Stars
- 43
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Description
Hi Jake,
I've spent some time reading through the access_point schema, without paying too much attention to anything other than the formatting of the file. Here are some notes to consider
- [x] Line 5: Title should be with a lowercase T
- [x] Line 71: coorindate_xyz has a typo, = coordinate
- [x] Line 74: I think coordinate_latlong technically should be coordinate_lat_long in snake_case. (Also line 207)
- [ ] Line 10: consider versioning within the properties of each schema. It can help with the different products integrating the schema, allowing them to verify the schema version in code
```
"properties": {
"version": {
"type": "string",
"description": "version of the OpenIntent schema",
"enum": [
"1.0.0"
]
}
}
```
- [ ] Line 134: Should this and Line 138 have a (or multiple) unit(s) specified (eg. dBm, mW)
- [ ] Line 229: Should there be a consideration for imperial measurements too? Like what has been done on line 200
Contributor guide
Assessment
This issue has not been assessed yet.