google / google/openhtf

Web launcher doesn't work on Windows

Open
#973 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
722
Forks
237
Avg merge
11h 31m
Merged PRs (30d)
4

Description

The code below is used to launch the web browser. The environment variable DISPLAY does not exist. Rather than having to create it, it should only use this environment variable on X Window based systems.

Maybe it should instead use if os.name == 'posix' :

```
def launch(url):
"""Attempt to launch the given URL."""
if os.environ.get('DISPLAY') is not None:
webbrowser.open(url)
return
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.