google / google/openhtf

UserInput Plug on Windows must be answered in ConsolePrompt

Open
#868 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
722
Forks
237
Avg merge
11h 31m
Merged PRs (30d)
4

Description

Adding the join function to ConsolePrompt.Stop in #862 prevents stopping a prompt in Windows because we can't use select to read from stdin, preventing us from stopping the read thread.

We can try something like https://stackoverflow.com/a/41812246.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.