google / google/openhtf

Register sigint handler on test execution not on import

Open
#814 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
722
Forks
237
Avg merge
11h 31m
Merged PRs (30d)
4

Description

We register a signint handler on import of openhtf here: https://github.com/google/openhtf/blob/master/openhtf/__init__.py#L76

Test.handle_sig_int does any okay job of just raising a KeyboardInterrupt if a test isn't actually running.

Would probably be better if we only registered this signal handler on test execution. I sometimes import openhtf to re-utilize some other utilities or plugs without using the majority of the framework and in these cases it's a little odd that openhtf is handling the sigint.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.