google / google/openhtf

plugs_test.py poorly isolated (relies upon socket)

Open
#753 0 comments 0 reactions 0 assignees View on GitHub
bug refactor/cleanup
Dominant language
Python
Stars
722
Forks
237
Avg merge
11h 31m
Merged PRs (30d)
4

Description

plugs_test.py is poorly isolated. It relies upon opening a socket.

I tried simply mocking out xmlrpcutil.SimpleThreadedXmlRpcServer which is used via the test plug which is a front end aware plug. However, still faced failures because I believe plug manager expects to be able to communicate with the front end aware plug over the socket.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.