google / google/open-location-code

CPP implementation: does not reference a required separator character

Open
#443 2 comments 0 reactions 0 assignees View on GitHub
c++
Dominant language
Java
Stars
4.4k
Forks
530
PR merge metrics
No merged PRs in 30d

Description

The C++ implementation states:

> // Returns an Open Location Code with code_length significant digits. The string
> // returned may be one character longer if it includes a separator character
> // for formatting.

This is underspecified. Every plus code will have a separator character. CITATION NEEDED. Therefore a better wording would be to say:

> // Returns an Open Location Code with code_length significant digits. The string
> // returned will be one character longer because it includes a separator character
> // for formatting.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.