Effect (Y or N) may be misleading
- Dominant language
- C++
- Stars
- 4.1k
- Forks
- 639
- Avg merge
- 2d 23h
- Merged PRs (30d)
- 8
Description
Currently in OboeTester, we have check box for effect and Y or N for if it was enabled or not. And then the effect will be set to enabled if the checkbox is checked. See code https://github.com/google/oboe/blob/56c587a79cd9081d006a5021aba1522fc01faf2d/apps/OboeTester/app/src/main/java/com/mobileer/oboetester/StreamConfigurationView.java#L613.
It may be confused as for all other check boxes, such as MMAP, they are checked if the users ask for it, and they have Yes or NO behind to indicate if they are actually used or not.
When first looking at the effect, I'm expecting they work similar as the MMAP checkbox. But they are not. I think it will be better to have consistent UI and have a better way to show case the effect was enabled and also indicator about if the effect is really created and enabled or not.
Contributor guide
Assessment
This issue has not been assessed yet.