fxlab should use std:shared_ptr and FullDuplexStream
Open
enhancement
P1
- Dominant language
- C++
- Stars
- 4.1k
- Forks
- 639
- Avg merge
- 2d 23h
- Merged PRs (30d)
- 8
Description
These changes are in one issue because the code for both changes are tightly coupled.
FXLab uses a custom DuplexCallback. It should use the new common class FullDuplexStream.
See LiveEffect for an example.
ManagedStream is deprecated and can lead to crashes.
Code in the [DuplexCallback](https://github.com/google/oboe/blob/ed079cfefc4022a2bd097108a4ff9be575033adf/apps/fxlab/app/src/main/cpp/DuplexEngine.h#L56).
Contributor guide
Assessment
This issue has not been assessed yet.