Flowgraph call count needs cleanup
- Dominant language
- C++
- Stars
- 4.1k
- Forks
- 639
- Avg merge
- 2d 23h
- Merged PRs (30d)
- 8
Description
We may be able to eliminate the need for mInputCallCount variable if we define:
```
/***************************************************************************/
int32_t FlowGraphPortFloatInput::pullData(int32_t numFrames) {
return (mConnected == nullptr)
? std::min(getFramesPerBuffer(), numFrames)
: mConnected->pullData(mConnected.getLastCallCount() + 1, numFrames); // use existing callcount
}
```
and call that from SampleRateConverter::isInputAvailable()
Argument order is inconsistent:
int32_t FlowGraphNode::pullData(int32_t numFrames, int64_t callCount) {
vs
int32_t FlowGraphPortFloatOutput::pullData(int64_t callCount, int32_t numFrames) {
Argument name does not match! framePosition != callCount
int32_t pullData(int64_t framePosition, int32_t numFrames) override;
Contributor guide
Assessment
This issue has not been assessed yet.