google / google/neuroglancer

Specs don't explain that annotations require a padding when the property group size approaches 255

Open
#845 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.5k
Forks
389
Avg merge
3d 21h
Merged PRs (30d)
3

Description

Reading the JS neuroglancer code for parsing the properties of annotations, I noticed that due some WebGL limitations, a modulo-4 byte padding is expected when the property group size approaches 255 bytes: https://github.com/google/neuroglancer/blob/249f866954c4069292c121eaa0592326b7277814/src/annotation/index.ts#L384

This is not mentioned [in the specs](https://github.com/google/neuroglancer/blob/master/src/datasource/precomputed/annotations.md), but I think it should, since otherwise an implementation for writing to the precomputed format may not cover this edge case.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.