google / google/neuroglancer

Changing layer type is easily destructive

Open
#570 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.5k
Forks
389
Avg merge
3d 21h
Merged PRs (30d)
3

Description

It is possible to change a layer type in the UI after it is already defined and in use. Since the layer type is immediately next to the various tool tabs, it is particularly easy to hit in tools like a graphene segmentation layer, where one often needs to move between different tabs to do work. If you accidentally change the layer type on such a misclick, all of the current settings are reset, which can destroy work. For example, accidentally changing the layer type of a segmentation layer removes all selected IDs and resets the various render settings like opacity.

In general, operation that destroy user work should probably be clearly deliberate and hard to trigger accidentally. I can imagine two solutions for this case, which are non-exclusive:
1) Have a confirmation dialogue for rare-but-destructive changes like changing the type for a non-fresh layer.
2) Implement a state-level "Undo," as was done in the older Seung-lab neuroglancer branch.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.