google / google/model-viewer

npmjs peerDependency for three is stuck at 0.172.0

Open
#5,087 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
8.2k
Forks
947
PR merge metrics
No merged PRs in 30d

Description

It seems that npmjs is serving @google/model-viewer with peerDependencies: { "three": "^0.172.0" }
[npmjs \@google\/model-viewer](https://www.npmjs.com/package/@google/model-viewer?activeTab=code)

Started a fresh project using pnpm with "@google/model-viewer": "4.1.0":

And digging into `node_modules/@google/model-viewer/package.json` I see:
```
"peerDependencies": {
"three": "^0.172.0"
},
```

Instead of what's in version control:
[model-viewer/package.json](https://github.com/google/model-viewer/tree/master/packages/model-viewer/package.json)

```
"peerDependencies": {
"three": "^0.174.0"
},
```

This means when using three.js in my own project, I want to avoid duplicate slightly different versions, I have to use the older 0.172.0 release. Weird.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.