google / google/ml-compiler-opt

ppo_nn_agent.gin hyperparam tuning

Open
#17 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
798
Forks
123
Avg merge
55m
Merged PRs (30d)
4

Description

Hi @yundiqian. I was skimming through the hyperparams of https://github.com/google/ml-compiler-opt/blob/main/compiler_opt/rl/inlining/gin_configs/ppo_nn_agent.gin and it seems counterintuitive to me that both `PPOAgent.normalize_rewards` and `PPOAgent.normalize_observations` are assigned as `False`. Would you be able to provide some info on it? Looking at the TF codebase (https://github.com/tensorflow/agents/blob/master/tf_agents/agents/ppo/ppo_agent.py#L206)), it is advised to normalize rewards and observation, so I was wondering if you had tried these out before?

Thanks!
-Amir

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.