google / google/minja

Switch to C++17

Open
#12 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
229
Forks
38
PR merge metrics
No merged PRs in 30d

Description

llama.cpp [just adopted it](https://github.com/ggerganov/llama.cpp/pull/10570), and that's also what [gemma.cpp](https://github.com/google/gemma.cpp) uses.

Some options:
- [x] Retire nonstd_make_unique backfill
- [x] Destructure pairs
- [ ] std::optional for attempted parsing
- [ ] std::variant for Value?
- [ ] More elegant function / filter definitions (leverage new auto inference)
- [ ] (in the process, optionally make the dep to json a bit looser to be able to switch to [json.cpp](https://github.com/jart/json.cpp))

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.