google / google/material-design-lite

Ripple container is a square during animation time

Open
#4,886 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
32.2k
Forks
4.9k
PR merge metrics
No merged PRs in 30d

Description

![e3047fb247562a440b925f674f9fa595](https://cloud.githubusercontent.com/assets/16016430/19825861/45dcd350-9d7f-11e6-97c7-9441c918fba8.gif)
(4 times slowed down ripple effect speed)

> What MDL Version are you using?

The one what is provided on getmdl.io : version v1.2.1

> What browser(s) is this bug affecting?

Google Chrome 54.0.2840.71 m (64-bit)
Opera 41.0.2353.46
Vivaldi 1.4.589.11 (Stable channel) (32-Bit)
Firefox 49.0.2

> **NOT** affected browsers:

Microsoft Edge 38.14393.0.0
Internet Explorer 11

> What OS (and version) are you using?

Windows 10 1607

> What are the steps to reproduce the bug?
1. Go to https://getmdl.io/components/index.html#buttons-section
2. Click and hold a button.

> What is the expected behavior?

Always visible border-radius

> What is the actual behavior?

While ripple is animating, the bounds of `.mdl-button__ripple-container` are square.
The `border-radius` of parent `.mdl-button` is ignored.

> Any other information you believe would be useful?

Adding `border-radius: inherit;` (or 2px) to `.mdl-button__ripple-container` will fix it.
https://github.com/google/material-design-lite/blob/88872e672e41c56af0a78a35b34373b8c4a8c49d/src/button/_button.scss#L224

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.