google / google/material-design-lite

Checkbox Ripple position

Open
#1,918 2 comments 0 reactions 0 assignees View on GitHub
Checkbox MD Alignment Ripple
Dominant language
HTML
Stars
32.2k
Forks
4.9k
PR merge metrics
No merged PRs in 30d

Description

Seems like Checkbox Ripple container aligned `1px` lower than it supposed to be.
![untitled-1](https://cloud.githubusercontent.com/assets/795984/11444910/81979dba-9530-11e5-8ed9-60e0448f2112.png)
![untitled-3](https://cloud.githubusercontent.com/assets/795984/11444913/83e294f8-9530-11e5-928e-d6dbc24addb0.png)

[Next](https://github.com/google/material-design-lite/blob/master/src/checkbox/_checkbox.scss#L154) code compiles to `6px` instead of `7px`.

``` sass
top: -(($checkbox-ripple-size - $checkbox-label-height) / 2);
```

Maybe, [this](https://github.com/google/material-design-lite/blob/master/src/_variables.scss#L421) section of [_variables.scss](https://github.com/google/material-design-lite/blob/master/src/_variables.scss) should be corrected.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.