google / google/material-design-lite

Datatable headers have wrong sizes and datatable doesn't have the correct borders when in a card

Open
#1,850 4 comments 0 reactions 0 assignees View on GitHub
Cards Data Table
Dominant language
HTML
Stars
32.2k
Forks
4.9k
PR merge metrics
No merged PRs in 30d

Description

The header of a data table should, according to the specs, have a 56dp height. Currently the implementation uses the same height as a normal row, 48dp. [0]

Also, the specs talk about embedding it within a card. When doing this the card header should be 64dp. Perhaps I'm using it wrong, but over here it renders with 61dp. [1]

The borders are also not correct. When in a card, the specs show the borders should wrap the card. The header then doesn't have a top-border, the last row does have a border and the footer also. Attached screenshots clearly shows the difference.

Specs:
[0] https://www.google.com/design/spec/components/data-tables.html#data-tables-specs
[1] https://www.google.com/design/spec/components/data-tables.html#data-tables-tables-within-cards
![image](https://cloud.githubusercontent.com/assets/383634/10975261/4e664af0-83e6-11e5-8990-7baea9c2f208.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.