google / google/material-design-lite

Ripple should be standalone component

Open
#1,783 3 comments 2 reactions 0 assignees View on GitHub
Button Checkbox Layout Menu Radio Ripple Switch Tabs
Dominant language
HTML
Stars
32.2k
Forks
4.9k
PR merge metrics
No merged PRs in 30d

Description

Currently the ripple effect is tightly bound to the other components using it, such as Radio and Button. This is because those other components are checking for the ripple js class, then creating the proper markup needed within themselves for it. Instead, the ripple component on its own should create the necessary markup in the container element. This will allow it to stand on its own for say, use in the navigation drawer on anchors.

Should be doable without breaking BC since the same class is currently required, we are just switching where the logic is done.

Files tied to creating the ripple container:

```
button.js
checkbox.js
icon-toggle.js
layout.js
menu.js
radio.js
switch.js
tabs.js
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.