google / google/material-design-lite

Allow further customization of sass mixins and variables

Open
#1,474 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
32.2k
Forks
4.9k
PR merge metrics
No merged PRs in 30d

Description

Currently mixins and variables are (re-)imported into sass partials

```
@import "../variables";
@import "../mixins";
```

https://github.com/google/material-design-lite/blob/master/src/textfield/_textfield.scss#L17

This means mixins, and variables without defaults can't be overridden:

```
@import "material-design-lite/src/variables";
@import "material-design-lite/src/mixins";
@import "project/variables";
@import "project/mixins";
```

The situations where I've run into this could be solved by [using more variables](https://github.com/google/material-design-lite/blob/master/src/_mixins.scss#L213) and [declaring all variables with !default](https://github.com/google/material-design-lite/blob/master/src/_variables.scss#L296) but that still leaves the problem of not being able to re-declare mixins if needed.

```
@import "project/variables";
@import "material-design-lite/src/variables";
@import "material-design-lite/src/mixins";
@import "project/mixins";
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.