google / google/loudness_ebur128

Public header has non-public include

Open
#2 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
9
Forks
4
PR merge metrics
No merged PRs in 30d

Description

The public header `ebur128_analyzer.h` includes `src/ebur128_constants.h` which is non-public:
https://github.com/google/loudness_ebur128/blob/6eb9930243db4b136684c24e982b81d8dcac6ab6/include/ebur128_analyzer.h#L24

I assume the intent is for the constants to be public as well?

I'm happy to open a PR for this if desired.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.