google / google/libprotobuf-mutator

ParsePartialFromString error not handled in mutator.cc

Open
#205 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
667
Forks
134
PR merge metrics
No merged PRs in 30d

Description

In https://github.com/google/libprotobuf-mutator/blob/ffd86a32874e5c08a143019aad1aaf0907294c9f/src/mutator.cc#L382, the Boolean result of ParsePartialFromString is not handled (by returning null).

This seems like an oversight.

But OTOH, it just allowed us to catch a bug in the proto parser library. So maybe it's on purpose?

Filing this in any case, so that the libprotobuf-mutator maintainers can decide.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.