google / google/libaddressinput

Wrong state_name_type for France

Open
#220 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
C++
Stars
624
Forks
109
PR merge metrics
No merged PRs in 30d

Description

France currently inherits the default (ZZ) state_name_type of "province".
But the correct state_name_type should be "region", as explained by @comxd in https://github.com/commerceguys/addressing/pull/161

```
Also, Google Maps API's provide a "region" for the "administrative_area_level_1" field. (@see https://developers.google.com/maps/documentation/javascript/geocoding?hl=fr#GeocodingAddressTypes)

Sources:

https://www.lefrancaisdesaffaires.fr/wp-content/uploads/2016/05/province_et_region.pdf
https://mediateur.radiofrance.com/infos/en-province-en-region/#:~:text=La%20locution%20la%20plus%20commune,parfait%20de%20%C2%AB%20en%20province%20%C2%BB.&text=En%20province%2C%20on%20a%20la,ne%20pas%20%C2%AB%20faire%20Paris%20%C2%BB.
```

This isn't noticeable because there are no regions defined for France by default, but there's no reason to show a wrong label when people do provide their own region list (in libraries that allow that).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.