Some Question about SaveValue function
- Dominant language
- C++
- Stars
- 39.4k
- Forks
- 8.2k
- PR merge metrics
- No merged PRs in 30d
Description
``static void SaveValue(void* arg, const Slice& ikey, const Slice& v) {
Saver* s = reinterpret_cast(arg);
ParsedInternalKey parsed_key;
if (!ParseInternalKey(ikey, &parsed_key)) {
s->state = kCorrupt;
} else {
if (s->ucmp->Compare(parsed_key.user_key, s->user_key) == 0) {
s->state = (parsed_key.type == kTypeValue) ? kFound : kDeleted;
if (s->state == kFound) {
s->value->assign(v.data(), v.size());
}
}
}
}
`
I see use useKey to Compare user key and target key ? Why not use internal-key?I think internal_key has unique SequenceNumber.
If do this,level 0 Major Compact don't need Get All OverLap files,Because we have unique SequenceNumber to find target Value
Contributor guide
Assessment
This issue has not been assessed yet.