google / google/leveldb

Make background thread stoppable

Open
#863 2 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
C++
Stars
39.4k
Forks
8.2k
PR merge metrics
No merged PRs in 30d

Description

Hi,

Current version of LevelDB has detached background thread that can't be stopped and each environment calls `std::abort()` in destructor.
This behavior prevents using of LevelDB in plugin dlls that can be started and stopped when main application still runs.

I think it is better to allow background thread to finish tasks in queue and then exit, when environment is being destroyed. That will make database loadable and unloadable.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.