Question: is leveldb::Options::reuse_logs stable enough for production usage?
- Dominant language
- C++
- Stars
- 39.4k
- Forks
- 8.2k
- PR merge metrics
- No merged PRs in 30d
Description
I can see that `reuse_logs` was added to `leveldb::Options` [about 5 years ago](https://github.com/google/leveldb/commit/ac1d69da31205a979b5a8510f33c31ae977530f0). This option has been [enabled](https://github.com/chromium/chromium/blob/master/third_party/leveldatabase/env_chromium.cc#L457-L469) in Chromium project some years ago on all platforms besides ChromeOS where this change resulted in data loss rate increase - [cr460568](https://bugs.chromium.org/p/chromium/issues/detail?id=460568). It seems the issue with ChromeOS has never been triaged because the workaround of not using `reuse_logs` was feasible on that OS but [presumably](https://bugs.chromium.org/p/chromium/issues/detail?id=460568#c19) the reason is that `fdatasync` on `eCryptfs` doesn't give the same guarantees as with other filesystems.
I'm wondering whether there are any other known issues with `reuse_logs` option being enabled. Are there any reasons why it is still considered experimental besides the above mentioned ChromeOS issue? My primary platforms of interest are Android, iOS and desktop Windows/Linux.
Contributor guide
Assessment
This issue has not been assessed yet.