google / google/leveldb

log_reader: Reader::Reader(...,initial_offset) usage always =0, should we simplify the code of log_reader

Open
#620 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
39.4k
Forks
8.2k
PR merge metrics
No merged PRs in 30d

Description

In `log_reader.cc`, it introduced a lot of logic to deal with `initial_offset`, but from the usage of the whole project, seems always uses `initial_offset = 0`.

Should delete the `initial_offset` parameter and simplify the code logic of `log_reader.cc` for `Reader::Reader`?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.