google / google/leveldb

overflow bug in SanitizeOptions

Open
#462 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
39.4k
Forks
8.2k
PR merge metrics
No merged PRs in 30d

Description

`ClipToRange(&result.max_open_files, 64 + kNumNonTableCacheFiles, 50000);`
`ClipToRange(&result.write_buffer_size, 64<<10, 1<<30);`
`ClipToRange(&result.max_file_size, 1<<20, 1<<30);`
`ClipToRange(&result.block_size, 1<<10, 4<<20);`

write_buffer_size=2<<30;
ClipToRange(&result.write_buffer_size, 64<<10, 1<<30);
// assert(write_buffer_size == 1<<30);
// write_buffer_size convert from size_t to int, overflow
assert(write_buffer_size == 64 << 10);

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.