google / google/leveldb

skiplist synchronization question

Open
#428 4 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
C++
Stars
39.4k
Forks
8.2k
PR merge metrics
No merged PRs in 30d

Description

The comment in the skiplist.h says like following:
```
void SkipList::Insert(const Key& key) {
// TODO(opt): We can use a barrier-free variant of FindGreaterOrEqual()
// here since Insert() is externally synchronized.
```
But when I following the source code, I found no external synchronization in db_impl.cc:DBImpl::Write.
```
// extract sequence and kType to insert memtable
status = WriteBatchInternal::InsertInto(updates, mem_);
```
Is this comment out of date or I missed something?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.