google / google/leveldb

Why usage_ in LRUCache::Insert from cache.cc just add charge?

Open
#327 1 comment 0 reactions 0 assignees View on GitHub
question
Dominant language
C++
Stars
39.4k
Forks
8.2k
PR merge metrics
No merged PRs in 30d

Description

``` c
usage_ += charge;
```

I think this better:

``` c
usage_ += charge + (sizeof(LRUHandle)-1 + key.size());
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.