google / google/leveldb

PosixSequentialFile::Skip(uint64_t n)

Open
#179 6 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
39.4k
Forks
8.2k
PR merge metrics
No merged PRs in 30d

Description

Original [issue 173](https://code.google.com/p/leveldb/issues/detail?id=173) created by guido.reina@yahoo.com on 2013-05-29T04:38:44.000Z:

The method PosixSequentialFile::Skip(uint64_t n) uses fseek, which is defined as:

``` c
int fseek(FILE *stream, long offset, int whence);
```

The problem is that "offset" is 4 bytes in 32bit machines.

Wouldn't it be better to use fseeko?

``` c
int fseeko(FILE *stream, off_t offset, int whence);
```

and in the Makefile have:
-D_FILE_OFFSET_BITS=64

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.