google / google/learned_optimization

jnp.sign(mean_rms) is always 1

Open
#279 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
814
Forks
73
Avg merge
9h 40m
Merged PRs (30d)
2

Description

In the list of features for nn_adam, you are using this feature, but if I understand correctly, this feature is always 1.
https://github.com/google/learned_optimization/blob/242e2180f03e8dfa72a08cd0d52126951b471909/learned_optimization/learned_optimizers/nn_adam.py#L305

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.