google / google/kctf

custom resource specs (cpu/mem requests/limits) of healthcheck container in challenge manifest has no effect

Open
#387 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
794
Forks
82
PR merge metrics
No merged PRs in 30d

Description

# Summary
Regardless of resources spec (cpu / mem requests / limits) of _healthcheck container_ in challenge manifest,

```yaml
# challenge manifest

apiVersion: kctf.dev/v1
kind: Challenge
metadata:
annotations: {}
name: asf
namespace: default
status:
health: healthy
status: Running
spec:
deployed: true
healthcheck:
enabled: true
image: >-
aaaa
image: >-
aaaa
network:
ports:
- domains:
- adsf.a.a.
name: ext
protocol: TCP
targetPort: 1337
public: false
podTemplate:
template:
spec:
containers:
- name: challenge
resources:
requests:
cpu: 1m
memory: 1Mi
- name: healthcheck
resources:
requests:
cpu: 1m
memory: 1Mi
```

resource spec of container in deployment is always set as below.

```yaml
# created deployment

- name: healthcheck
image: >-
abc
resources:
limits:
cpu: '1'
requests:
cpu: 50m
```

# Expected behaviour
Resource specs of healthcheck container in deployment must be same as what specified in challenge.yaml.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.