google / google/jsonnet

"eval" JSON manifestation indentation should match "fmt" default (3 v. 2)

Open
#547 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Jsonnet
Stars
7.6k
Forks
475
PR merge metrics
No merged PRs in 30d

Description

When running the _eval_ subcommand and manifesting JSON, _jsonnet eval_ uses **three spaces** for its indentation step, per the `manifestJSON` function in file _core/vm.cpp_ (specifically, [here for arrays](https://github.com/google/jsonnet/blob/master/core/vm.cpp#L2558) and [here for objects](https://github.com/google/jsonnet/blob/master/core/vm.cpp#L2604)). By contrast, the _fmt_ uses **two spaces** for [its default indentation step](https://github.com/google/jsonnet/blob/master/core/formatter.h#L37).

Why do these two subcommands differ in their indentation? It wouldn't matter as much if either they matched, or the indentation used by the _eval_ subcommand was configurable via command-line flag. I'd prefer that they matched at two spaces per step.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.