google / google/jsonnet

Formatter should handle [{...}] better

Open
#230 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Jsonnet
Stars
7.6k
Forks
475
PR merge metrics
No merged PRs in 30d

Description

jsonnet fmt changed the following code from:

```
volumeMounts: [
{
name: "deployment-config",
mountPath:
if cluster.isLocal then
"/box/deployment-config"
else
"/box"
,
},
],
```

to:

```
volumeMounts: [
{
name: "deployment-config",
mountPath:
if cluster.isLocal then
"/box/deployment-config"
else
"/box",
},
],
```

which is mis-indented. My personal taste would have had the whole thing turned to:

```
volumeMounts: [{
name: "deployment-config",
mountPath:
if cluster.isLocal then
"/box/deployment-config"
else
"/box",
}],
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.