google / google/jaxopt

Use linesearch API in GradientDescent and ArmijoSGD

Open
#483 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
1.1k
Forks
76
Avg merge
2d 21h
Merged PRs (30d)
1

Description

`GradientDescent` is currently just a subclass of `ProximalGradient`, which means that it only supports FISTA's linesearch.

`ArmijoSGD` also implements its own Armijo linesearch.

In both cases, it would be better to use our linesearch API. This would allow us to support more linesearch strategies and would reduce code duplication.

In that case, it's not clear if we need to keep the two classes or just keep one of the two.

@vroulet @Algue-Rythme

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.