google / google/jaxopt

Should `solve_inv` be `solve_pinv` ?

Open
#309 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1.1k
Forks
76
Avg merge
2d 21h
Merged PRs (30d)
1

Description

I'm looking at https://github.com/google/jaxopt/blob/ddd6c30953f6c02d8022c1358aa67d9114aed3a6/jaxopt/_src/linear_solve.py#L93

In most cases, when solving a linear system, we're interested in using the pseudo inverse. Should the call be to `jnp.linalg.pinv` instead of `inv` ?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.