google / google/j2objc

Several RxJava Tests failing

Open
#685 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
6k
Forks
999
Avg merge
19h 20m
Merged PRs (30d)
14

Description

I recently started transpiling RxJava so I thought I'd run the RxJava tests and confirm if's safe to use. I had to comment out 3 or 4 tests, because they couldn't compile due to dependencies on `System.gc()`, and some other stuff. After that, the tests compiled just fine. I'm seeing a lot of tests failing though which makes me question whether or not it's safe to be using this library in a transpiled state.

**Modified Sources so that the tests compile**: [rxjava-src-1.1.0.zip](https://github.com/google/j2objc/files/71976/rxjava-src-1.1.0.zip)
**Results from running the tests:** [rxjava-tests-result.txt](https://github.com/google/j2objc/files/71977/rxjava-tests-result.txt)

I had [found a post](https://groups.google.com/forum/#!topic/j2objc-discuss/3eAwseG4Nms) where @tomball a few months ago said he was able to get many of the RxJava tests to pass after removing the tests that wouldn't compile (as mentioned above). **Some of the tests appear to fail because they don't complete before the timeout, and some appear to fail because of unexpected results or exceptions.** I'm not really sure what to do with failing tests. Is that something I can fix?

I'm wondering if:
1. I'm compiling the sources wrong
2. These tests were added to rxjava after @tomball had them working, or if the source was modified, causing these issues with j2objc
3. j2objc is compiling the tests / sources incorrectly

Note: You'll notice in the test results I posted that I ran each test individually. That's because I found if I ran all the tests with a single command, I'd get a segfault error.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.