google / google/ide-perf

VFS Tracer broke

Open
#47 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
67
Forks
15
PR merge metrics
No merged PRs in 30d

Description

Worse, the error message is unreadable (the text is confined to an itty-bitty square somehow). However, thanks to the UI Inspector, I can recover the HTML for the error message. (The whitespace was somewhat mangled, so I've tweaked it.)

```html



<!--
body { font-family: Segoe UI; font-size: 12pt; color: #d4d4d4 }
div { font-family: Segoe UI; font-size: 12pt; color: #d4d4d4 }
td { font-family: Segoe UI; font-size: 12pt; color: #d4d4d4 }
p { font-family: Segoe UI; font-size: 12pt; color: #d4d4d4 }
a { font-family: Segoe UI; font-size: 12pt; color: #ede891 }
code { font-size: 12pt }
ul { list-style: disc; margin-left: 15px }
-->



Detected a breaking change. Cannot find
com.intellij.psi.stubs.StubIndexImpl::createPsiNoLock.


```

However, it seems that this instance of `createPsiNoLock` is a copy and paste error: the method in question is actually named `processElements`:

https://github.com/google/ide-perf/blob/3610383c3ad69b7ad0509a881a033687a01194fa/src/main/java/com/google/idea/perf/vfstracer/VirtualFileTracer.kt#L252

It looks like this got moved to `com.intellij.psi.stubs.StubIndexEx#processElements` in commit
https://github.com/JetBrains/intellij-community/commit/7aa4148d5e746e99fe42cb229f33928d7549e606.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.