google / google/iconvg

cowbell.svg includes a lot of unnecessary stuff

Open
#28 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
C
Stars
694
Forks
10
PR merge metrics
No merged PRs in 30d

Description

This is an interesting project, but to make a better case against the size of SVG, your cowbell.svg example should probably be more representative of how it should be used for final-form delivery.

For example, it has the following style attribute on a `path` element:

```
color-rendering:auto;text-decoration-color:#000000;color:#000000;isolation:auto;mix-blend-mode:normal;shape-rendering:auto;solid-color:#000000;block-progression:tb;text-decoration-line:none;image-rendering:auto;white-space:normal;text-indent:0;text-transform:none;text-decoration-style:solid
```

I'm not even sure what tool would put those there - text properties on a `path`?? But also I think each of them is the default value anyway.

Many of the elements have an unnecessary id attribute.

The file also defines the `rdf` namespace, the creative commons namespace, and the dc namespace - none of which are used in the content.

Maybe it should be run through some optimisation tool before being used as an example?

(Side note: the actual transfer size of the SVG is about 2.7Kb)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.