google / google/heir

Add support for non-control-flow region-bearing ops in SecretnessAnalysis

Open
#888 4 comments 0 reactions 1 assignee Claimed by @AlexanderViand-Intel View on GitHub
dialect: secret
Dominant language
MLIR
Stars
906
Forks
171
Avg merge
4d 12h
Merged PRs (30d)
32

Description

The fix for #839 conservatively marks region-bearing ops not handled by the analysis framework directly (i.e. no `RegionBranchOpInterface` trait) as "unknown" secretness (unless there's a secret operand, in which case it's secret irrespective of regions). This is correct, but overly conservative, as we could set the secretness to false if none of the operations in the op's regions are "secret" (That's still somewhat conservative, but probably the best we can do without assuming something about the operation's semantics). Supporting this requires implementing `visitNonControlFlowArguments`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.