google / google/heir

Determine if nested `AlignRotations` patterns are still necessary

Open
#579 1 comment 0 reactions 0 assignees View on GitHub
dialect: tensor_ext good first issue
Dominant language
MLIR
Stars
906
Forks
171
Avg merge
4d 12h
Merged PRs (30d)
32

Description

While debugging https://github.com/google/heir/issues/578, it seemed to me that the buggy pattern `AlignRotations_RightAssociated_Inner_#InnerOp#_Outer_#OuterOp` (and its related LeftAssociated version) are not doing anything. It seems like they are no-ops, but we might want to determine if they are still providing any value, and remove them if not.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.