google / google/heir

SCIFRBool - Update SectionOp generation pass

Open
#2,738 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
MLIR
Stars
906
Forks
171
Avg merge
4d 12h
Merged PRs (30d)
32

Description

The lack of a terminator on `section`, plus this code, makes the implicit assumption that only the results of the very last op in a `section` are the output of the entire `section` op. If you want to be able to have a section produce multiple results, you would probably need a terminator at that point.

If these are the intended semantics of `section`, this should be added to the tablegen description for the `section` op.

_Originally posted by @j2kun in https://github.com/google/heir/pull/2594#discussion_r2885616203_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.