google / google/heir

Detect float point type earlier in BGV pipeline

Open
#1,397 3 comments 0 reactions 0 assignees View on GitHub
dialect: bgv
Dominant language
MLIR
Stars
906
Forks
171
Avg merge
4d 12h
Merged PRs (30d)
32

Description

Currently the detection of float point type and the warning for it is in `--secret-to-bgv`. However, earlier pass like `--validate-noise` assumes input in BGV style, and float point input to it will segfault.

As we put the scheme flag in the pipeline like `--mlir-to-bgv`, we know the scheme parameter from the begining so we could reject it earlier.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.