google / google/hctr2

Linux test vectors: assign key length, message size, tweak size randomly

Open
#9 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
45
Forks
3
PR merge metrics
No merged PRs in 30d

Description

@ebiggers writes:

> This PR makes it so that there are two test vectors per message size per key size, so 6 total per message size. Maybe cut that down to 1 per message size per key size, so 3 total per message size? Or even less and just assign key sizes randomly.

> not very effective to have 2 test vectors per message length per key length. Problems are more likely to arise for different length inputs, not for different input contents. The xctr test vectors are especially odd, as they only test 32 and 255-byte messages, but have 6 test vectors for each length. We could get better test coverage in the same number (or fewer) of test vectors by focusing on different lengths rather than different contents.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.