google / google/gvisor

Remove (or use) network stats that are never incremented

Open
#5,597 1 comment 0 reactions 0 assignees View on GitHub
area: networking type: enhancement
Dominant language
Go
Stars
19.3k
Forks
2k
Avg merge
3d 5h
Merged PRs (30d)
264

Description

**Description**

Some stats can never be incremented, they should be removed or incremented where possible.

**Do you have a specific solution in mind?**

An example of such stat is ICMP.V{4,6}.PacketsSent.Echo. It is never incremented. In `transport/icmp/endpoint.go`, it should be incremented when an outgoing Echo packet is sent.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.