google / google/gvisor

Use helper functions to start neighbor entry tests in their expected state

Open
#4,872 0 comments 0 reactions 1 assignee Claimed by @puradox View on GitHub
type: enhancement
Dominant language
Go
Stars
19.3k
Forks
2k
Avg merge
3d 5h
Merged PRs (30d)
264

Description

**Description**

There is currently repeated code within the neighbor entry tests (See `//pkg/tcpip/stack/neighbor_entry_test.go`). This is most evident by the tests that start in the later states, such as Failed. These tests first have to get the entry to transition into Failed state. This works great for being able to track the state transitions all the way through, but adds noise to the tests.

**Do you have a specific solution in mind?**

This issue proposes to use helper functions to transition the neighbor entry to the expected state before testing the intended functionality.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.